From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1WF6CP-0004j0-Ad
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 13:12:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1WF6CO-0007TT-2u
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 13:12:17 -0500
Received: from hall.aurel32.net ([2001:bc8:30d7:101::1]:43456)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1WF6CN-0007TB-Sn
	for qemu-devel@nongnu.org; Sun, 16 Feb 2014 13:12:16 -0500
Date: Sun, 16 Feb 2014 19:12:15 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20140216181215.GA18666@hall.aurel32.net>
References: <1391179418-13422-1-git-send-email-rth@twiddle.net>
	<1391179418-13422-3-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1391179418-13422-3-git-send-email-rth@twiddle.net>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 2/5] tcg/i386: Move TCG_CT_CONST_* to
	tcg-target.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Fri, Jan 31, 2014 at 08:43:35AM -0600, Richard Henderson wrote:
> These are not needed by users of tcg-target.h.  No need to recompile
> when we adjust them.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/i386/tcg-target.c | 4 ++++
>  tcg/i386/tcg-target.h | 3 ---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index 5d4cf93..7008b0e 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -88,6 +88,10 @@ static const int tcg_target_call_oarg_regs[] = {
>  #endif
>  };
>  
> +/* Constants we accept.  */
> +#define TCG_CT_CONST_S32 0x100
> +#define TCG_CT_CONST_U32 0x200
> +
>  /* Registers used with L constraint, which are the first argument 
>     registers on x86_64, and two random call clobbered registers on
>     i386. */
> diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h
> index 92c0fcd..747b797 100644
> --- a/tcg/i386/tcg-target.h
> +++ b/tcg/i386/tcg-target.h
> @@ -64,9 +64,6 @@ typedef enum {
>      TCG_REG_RDI = TCG_REG_EDI,
>  } TCGReg;
>  
> -#define TCG_CT_CONST_S32 0x100
> -#define TCG_CT_CONST_U32 0x200
> -
>  /* used for function call generation */
>  #define TCG_REG_CALL_STACK TCG_REG_ESP 
>  #define TCG_TARGET_STACK_ALIGN 16

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net