From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WFIz1-0002F3-Fy
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 02:51:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WFIyw-0006Q3-KO
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 02:51:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38685)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WFIyw-0006Pw-AL
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 02:51:14 -0500
Date: Mon, 17 Feb 2014 09:56:03 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140217075603.GA18334@redhat.com>
References: <1392293009-13812-1-git-send-email-a.motakis@virtualopensystems.com>
	<1392293009-13812-2-git-send-email-a.motakis@virtualopensystems.com>
	<5446ebb6-aeff-48dc-b97e-b9a1bfcdfb68@email.android.com>
	<53014CF5.8070600@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <53014CF5.8070600@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v8 01/17] Convert -mem-path to QemuOpts and
 add prealloc and share properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, snabb-devel@googlegroups.com, Stefan Hajnoczi <stefanha@redhat.com>, Juan Quintela <quintela@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org, n.nikolaev@virtualopensystems.com, Alexander Graf <agraf@suse.de>, Anthony Liguori <aliguori@amazon.com>, lukego@gmail.com, Antonios Motakis <a.motakis@virtualopensystems.com>, tech@virtualopensystems.com, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Mon, Feb 17, 2014 at 12:42:45AM +0100, Paolo Bonzini wrote:
> Il 15/02/2014 19:10, Michael Tokarev ha scritto:
> > 13 =D1=84=D0=B5=D0=B2=D1=80=D0=B0=D0=BB=D1=8F 2014 =D0=B3. 16:03:12 G=
MT+04:00, Antonios Motakis <a.motakis@virtualopensystems.com> =D0=BF=D0=B8=
=D1=88=D0=B5=D1=82:
> >> Extend -mem-path with additional properties:
> >>
> >> - prealloc=3Don|off - default off, same as -mem-prealloc
> >> - share=3Don|off - default off, memory is mmapped with MAP_SHARED
> >=20
> > Maybe we should combine -m and -mem-path options together to form som=
ething more sane?
>=20
> It's on the way: it would be something like
>=20
>    -object mem-file,size=3D1024M,path=3D/path/to/foo,share=3Don,preallo=
c=3Don,id=3Dmem \
>    -numa node,memdev=3Dmem
>=20
> using the same host/guest split model that is already in use
> in many other places.  Not 2.0 material though.
>=20
> Paolo

Hmm in that case, let's not add prealloc as a property here.
Stick to existing flag for that, this way we don't need
to support 3 ways to do this.