From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFOxE-000339-67 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 09:13:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFOx8-0002q0-6h for qemu-devel@nongnu.org; Mon, 17 Feb 2014 09:13:52 -0500 Received: from 28-113-190-109.dsl.ovh.fr ([109.190.113.28]:53373 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFOx7-0002pr-V5 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 09:13:46 -0500 Date: Mon, 17 Feb 2014 14:35:07 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140217133507.GA3136@irqsave.net> References: <1392435024-26694-1-git-send-email-mreitz@redhat.com> <20140217124243.GH3502@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140217124243.GH3502@dhcp-200-207.str.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 0/8] block: Integrate bdrv_file_open() into bdrv_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Jeff Cody , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz The Monday 17 Feb 2014 =E0 13:42:43 (+0100), Kevin Wolf wrote : > Am 15.02.2014 um 04:30 hat Max Reitz geschrieben: > > bdrv_file_open() is now nearly a subset of bdrv_open(), except for th= e > > fact that bdrv_file_open() is for protocols and bdrv_open() for block > > drivers. It is possible to use bdrv_file_open() with a block driver, = but > > in that case that block driver must be explicitly specified. > >=20 > > Due to these great similarities, bdrv_file_open() can be integrated a= nd > > made a special case of bdrv_open(). If the flag BDRV_O_PROTOCOL is > > specified, bdrv_open() will now do what bdrv_file_open() used to do: > > Auto-detecting a protocol instead of a block driver. > >=20 > > This series implements this and changes all calls to bdrv_file_open()= to > > bdrv_open() calls with BDRV_O_PROTOCOL specified. > >=20 > > Note that this flag cannot be discerned automatically since it is > > impossible for bdrv_open() to know by itself whether a given file sho= uld > > be opened with or without the format layer involved: Both are valid > > alternatives. Therefore, it still has to be specified by the user. >=20 > This series conflicts with Beno=EEt's patches that have been merged int= o > master. When rebasing, please be careful with the code motion patch so > that you don't accidentally revert Beno=EEt's changes. (It's an easy > conflict to resolve, but not trivial enough for me to do it while > applying the patch, with no additional review.) >=20 > Kevin I will do another review once Max has rebased and resent this series. Best regards Beno=EEt >=20