From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57244)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WFbzS-0006zn-Kv
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 23:09:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WFbzM-0005Tw-Lv
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 23:09:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:6407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WFbzM-0005Tr-EE
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 23:08:56 -0500
Date: Tue, 18 Feb 2014 12:06:57 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140218040657.GA7579@T430.redhat.com>
References: <1392242799-16364-1-git-send-email-benoit.canet@irqsave.net>
	<1392242799-16364-12-git-send-email-benoit.canet@irqsave.net>
	<20140213090949.GB3119@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140213090949.GB3119@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and
	quorum_close().
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

On Thu, 02/13 10:09, Beno=EEt Canet wrote:
> The Wednesday 12 Feb 2014 =E0 23:06:38 (+0100), Beno=EEt Canet wrote :
> > +static void quorum_close(BlockDriverState *bs)
> > +{
> > +    BDRVQuorumState *s =3D bs->opaque;
> > +    int i;
> > +
> > +    for (i =3D 0; i < s->num_children; i++) {
> > +        bdrv_unref(s->bs[i]);
> Quorum crash here from time to time I don't understand why.

I think you could add printf or use gdb to examine every bdrv_unref on th=
e
crashing bs, so you can track down to the unbalanced reference.

Fam