From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFhzR-0007aA-L5 for qemu-devel@nongnu.org; Tue, 18 Feb 2014 05:33:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFhzL-0007SK-MB for qemu-devel@nongnu.org; Tue, 18 Feb 2014 05:33:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFhzL-0007S9-Eg for qemu-devel@nongnu.org; Tue, 18 Feb 2014 05:33:19 -0500 Date: Tue, 18 Feb 2014 10:32:31 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20140218103230.GD2662@work-vm> References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-3-git-send-email-mrhines@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392713429-18201-3-git-send-email-mrhines@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, quintela@redhat.com, BIRAN@il.ibm.com, hinesmr@cn.ibm.com, qemu-devel@nongnu.org, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, junqing.wang@cs2c.com.cn, lig.fnst@cn.fujitsu.com, gokul@us.ibm.com, dbulkow@gmail.com, pbonzini@redhat.com, abali@us.ibm.com, isaku.yamahata@gmail.com, "Michael R. Hines" * mrhines@linux.vnet.ibm.com (mrhines@linux.vnet.ibm.com) wrote: > From: "Michael R. Hines" > > We also later export these statistics over QMP for better > monitoring of micro-checkpointing as the workload changes. > @@ -548,9 +568,11 @@ static int ram_save_block(QEMUFile *f, bool last_stage) > /* XBZRLE overflow or normal page */ > if (bytes_sent == -1) { > bytes_sent = save_block_hdr(f, block, offset, cont, RAM_SAVE_FLAG_PAGE); > - qemu_put_buffer_async(f, p, TARGET_PAGE_SIZE); > - bytes_sent += TARGET_PAGE_SIZE; > - acct_info.norm_pages++; > + if (ret != RAM_SAVE_CONTROL_DELAYED) { > + qemu_put_buffer_async(f, p, TARGET_PAGE_SIZE); > + bytes_sent += TARGET_PAGE_SIZE; > + acct_info.norm_pages++; > + } > } Is that last change intended for this patch; it doesn't look timestamp related. Dave -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK