From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open
Date: Wed, 19 Feb 2014 10:34:29 +0100 [thread overview]
Message-ID: <20140219093429.GC12570@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <1392644647-9897-7-git-send-email-pbonzini@redhat.com>
On Mon, Feb 17, 2014 at 02:43:53PM +0100, Paolo Bonzini wrote:
> Before:
> $ ./qemu-io-old
> qemu-io-old> open -r -o file.driver=iscsi,file.filename=foo
> Failed to parse URL : foo
> qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument
>
> After:
> $ ./qemu-io
> qemu-io> open -r -o file.driver=iscsi,file.filename=foo
> qemu-io: can't open device (null): Failed to parse URL : foo
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/iscsi.c | 103 ++++++++++++++++++++++++++++++----------------------------
> 1 file changed, 53 insertions(+), 50 deletions(-)
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2014-02-19 9:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 13:43 [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 01/20] nbd: produce a better error if neither host nor port is passed Paolo Bonzini
2014-02-17 18:48 ` Eric Blake
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 02/20] nbd: correctly propagate errors Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 03/20] nbd: inline tcp_socket_incoming_spec into sole caller Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 04/20] nbd: move socket wrappers to qemu-nbd Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 05/20] iscsi: fix indentation Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open Paolo Bonzini
2014-02-19 9:34 ` Stefan Hajnoczi [this message]
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 07/20] gluster: default scheme to gluster:// and host to localhost Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 08/20] gluster: correctly propagate errors Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 09/20] cow: " Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 10/20] curl: " Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 11/20] qcow: " Paolo Bonzini
2014-02-17 13:43 ` [Qemu-devel] [PATCH v3 12/20] qed: " Paolo Bonzini
2014-02-17 13:44 ` [Qemu-devel] [PATCH v3 13/20] vhdx: " Paolo Bonzini
2014-02-17 14:38 ` Jeff Cody
2014-02-17 13:44 ` [Qemu-devel] [PATCH v3 14/20] vvfat: " Paolo Bonzini
2014-02-17 13:44 ` [Qemu-devel] [PATCH v3 15/20] vmdk: extract vmdk_read_desc Paolo Bonzini
2014-02-17 13:44 ` [Qemu-devel] [PATCH v3 16/20] vmdk: push vmdk_read_desc up to caller Paolo Bonzini
2014-02-17 13:44 ` [Qemu-devel] [PATCH v3 17/20] vmdk: do not try opening a file as both image and descriptor Paolo Bonzini
2014-02-17 13:44 ` [Qemu-devel] [PATCH v3 18/20] vmdk: correctly propagate errors Paolo Bonzini
2014-02-17 13:44 ` [Qemu-devel] [PATCH v3 19/20] block: do not abuse EMEDIUMTYPE Paolo Bonzini
2014-02-17 13:44 ` [Qemu-devel] [PATCH v3 20/20] vdi: say why an image is bad Paolo Bonzini
2014-02-18 6:32 ` [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages Fam Zheng
2014-02-19 14:06 ` Kevin Wolf
2014-02-20 17:29 ` Paolo Bonzini
2014-02-21 11:08 ` Kevin Wolf
2014-02-21 11:37 ` Paolo Bonzini
2014-02-21 11:47 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2014-02-14 16:20 [Qemu-devel] [PATCH v2 06/20] iscsi: correctly propagate errors in iscsi_open Stefan Hajnoczi
2014-02-14 16:47 ` [Qemu-devel] [PATCH v3 " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219093429.GC12570@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).