From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH v4 0/8] block: Integrate bdrv_file_open() into bdrv_open()
Date: Wed, 19 Feb 2014 10:47:33 +0100 [thread overview]
Message-ID: <20140219094733.GC3613@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1392744792-9512-1-git-send-email-mreitz@redhat.com>
Am 18.02.2014 um 18:33 hat Max Reitz geschrieben:
> bdrv_file_open() is now nearly a subset of bdrv_open(), except for the
> fact that bdrv_file_open() is for protocols and bdrv_open() for block
> drivers. It is possible to use bdrv_file_open() with a block driver, but
> in that case that block driver must be explicitly specified.
>
> Due to these great similarities, bdrv_file_open() can be integrated and
> made a special case of bdrv_open(). If the flag BDRV_O_PROTOCOL is
> specified, bdrv_open() will now do what bdrv_file_open() used to do:
> Auto-detecting a protocol instead of a block driver.
>
> This series implements this and changes all calls to bdrv_file_open() to
> bdrv_open() calls with BDRV_O_PROTOCOL specified.
>
> Note that this flag cannot be discerned automatically since it is
> impossible for bdrv_open() to know by itself whether a given file should
> be opened with or without the format layer involved: Both are valid
> alternatives. Therefore, it still has to be specified by the user.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2014-02-19 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 17:33 [Qemu-devel] [PATCH v4 0/8] block: Integrate bdrv_file_open() into bdrv_open() Max Reitz
2014-02-18 17:33 ` [Qemu-devel] [PATCH v4 1/8] block: Change BDS parameter of bdrv_open() to ** Max Reitz
2014-02-18 17:33 ` [Qemu-devel] [PATCH v4 2/8] block: Add reference parameter to bdrv_open() Max Reitz
2014-02-18 17:33 ` [Qemu-devel] [PATCH v4 3/8] block: Make bdrv_file_open() static Max Reitz
2014-02-18 17:33 ` [Qemu-devel] [PATCH v4 4/8] block: Reuse reference handling from bdrv_open() Max Reitz
2014-02-18 17:33 ` [Qemu-devel] [PATCH v4 5/8] block: Remove bdrv_new() from bdrv_file_open() Max Reitz
2014-02-18 17:33 ` [Qemu-devel] [PATCH v4 6/8] block: Handle bs->options in bdrv_open() only Max Reitz
2014-02-18 17:33 ` [Qemu-devel] [PATCH v4 7/8] block: Reuse success path from bdrv_open() Max Reitz
2014-02-18 17:33 ` [Qemu-devel] [PATCH v4 8/8] block: Remove bdrv_open_image()'s force_raw option Max Reitz
2014-02-19 9:47 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219094733.GC3613@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=benoit@irqsave.net \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).