qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel <qemu-devel@nongnu.org>, Stefan Weil <sw@weilnetz.de>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [Qemu-devel] Buildbot failure: MinGW
Date: Wed, 19 Feb 2014 13:18:37 +0100	[thread overview]
Message-ID: <20140219131837.2d37e2d3@oc7435384737.ibm.com> (raw)
In-Reply-To: <CAFEAcA91TaWhUXKF72Qhpd0qDmNYzKaU63rC2d1sz2A7pui+Nw@mail.gmail.com>

On Wed, 19 Feb 2014 11:53:09 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 19 February 2014 04:27, Stefan Weil <sw@weilnetz.de> wrote:
> > Hi Gerd, hi Stefan,
> >
> > we now need a C++ compiler on the buildbots. Currently, it's missing for
> > MinGW:
> >
> > /bin/sh: i686-pc-mingw32-g++: command not found
> 
> Don't we successfully fall back to "don't build C++ things" if
> configure doesn't detect the C++ compiler?

I recently had a similar problem compiling QEMU on a freshly installed
system, where I only had a normal C compiler, but no C++ installed yet.

In rules.mak, you can find these lines:

 # If we have a CXX we might have some C++ objects, in which case we
 # must link with the C++ compiler, not the plain C compiler.
 LINKPROG = $(or $(CXX),$(CC))

So that's ok, it sets LINKPROG to the c++ compiler if the variable is
set, and to the C compiler if not.

But now have a look at the configure script:

 if test -z "${CXX}${cross_prefix}"; then
   cxx="c++"
 else
   cxx="${CXX-${cross_prefix}g++}"
 fi

 [...]

 echo "CXX=$cxx" >> $config_host_mak

That seems to always set the CXX variable! I think the above
if-statement is wrong, it should set cxx only if the c++ program is
really available.

 Thomas

  reply	other threads:[~2014-02-19 12:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAJSP0QXtiYBE5xEgKwzy7hghT8=QPM_VfWdmMbWq1kJWJZC9LQ@mail.gmail.com>
2013-11-20  9:16 ` [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error Stefan Hajnoczi
2013-11-20 17:40   ` Tomoki Sekiyama
2013-11-20 17:49     ` Stefan Weil
2013-11-21  8:40     ` Stefan Hajnoczi
2013-11-22  6:56       ` [Qemu-devel] Buildbot failure: MinGW (was: qga/vss-win32/requester.h compile error) Stefan Weil
2013-11-22 10:54         ` Stefan Hajnoczi
2013-11-22 12:51           ` Gerd Hoffmann
2013-11-24 10:21             ` [Qemu-devel] Buildbot failure: MinGW Stefan Weil
2013-11-25  7:00               ` Gerd Hoffmann
2014-02-19  4:27                 ` Stefan Weil
2014-02-19 10:05                   ` Gerd Hoffmann
2014-02-19 11:53                   ` Peter Maydell
2014-02-19 12:18                     ` Thomas Huth [this message]
2014-02-19 13:07                       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140219131837.2d37e2d3@oc7435384737.ibm.com \
    --to=thuth@linux.vnet.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).