From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WG8PE-0004h5-H4
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 09:45:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WG8P8-0001cJ-By
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 09:45:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WG8P7-0001bw-T2
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 09:45:42 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1JEjbW9001392
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 19 Feb 2014 09:45:40 -0500
Date: Wed, 19 Feb 2014 15:06:16 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140219140616.GG3613@dhcp-200-207.str.redhat.com>
References: <1392644647-9897-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1392644647-9897-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 00/20] Improve bdrv_open error messages
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: jcody@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Am 17.02.2014 um 14:43 hat Paolo Bonzini geschrieben:
> Most of the block drivers are not using the Error** argument to bdrv_open,
> and instead just printing errors to stderr.  This series improves that,
> and as a consequence it also avoids abuse of errno numbers.
> 
> The only hurdle (caught by qemu-iotests, too) is VMDK, where we currently
> parse a file first as image, and second as a descriptor.  This makes
> it hard to pick a good error message, because you do not know which
> attempt gave the most reasonable error message.  For this reason patches
> 15-17 modify this approach and push up the detection of vmdk image file
> magic numbers.
> 
> Apart from this, and from a segfault fixed by patch 7, the series consists
> of mostly trivial patches.

Thanks, applied to the block branch.

Kevin