From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33265)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WGCVM-0005Ha-Ht
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 14:08:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WGCVB-0001ea-GW
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 14:08:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:6841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WGCVB-0001dE-7V
	for qemu-devel@nongnu.org; Wed, 19 Feb 2014 14:08:13 -0500
Date: Wed, 19 Feb 2014 21:13:11 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140219191311.GC24622@redhat.com>
References: <1392821892-26682-1-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1392821892-26682-1-git-send-email-ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] Enable x2apic by default on KVM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Wed, Feb 19, 2014 at 11:58:09AM -0300, Eduardo Habkost wrote:
> This is the approach I believe was agreed upon during the last QEMU developers
> conf call (sorry I didn't join, the meeting timezone change confused me).

Yes.

> Some may notice that representing this new behavior using solely default values
> on CPU properties may be a little difficult. Making it possible to replace
> x86_cpu_compat_disable_kvm_features() with compat_props entries may be an
> interesting problem, too.

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> 
> Eduardo Habkost (3):
>   target-i386: Make kvm_default_features an array
>   target-i386: Introduce x86_cpu_compat_disable_kvm_features()
>   target-i386: Enable x2apic by default on KVM
> 
>  hw/i386/pc_piix.c |  7 ++++---
>  hw/i386/pc_q35.c  |  2 ++
>  target-i386/cpu.c | 20 +++++++++++++++-----
>  target-i386/cpu.h |  4 ++--
>  4 files changed, 23 insertions(+), 10 deletions(-)
> 
> -- 
> 1.8.5.3