From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGLsW-0006O8-6I for qemu-devel@nongnu.org; Thu, 20 Feb 2014 00:09:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGLsQ-0004j3-7L for qemu-devel@nongnu.org; Thu, 20 Feb 2014 00:08:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25882) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGLsP-0004iw-Uo for qemu-devel@nongnu.org; Thu, 20 Feb 2014 00:08:50 -0500 Date: Thu, 20 Feb 2014 07:13:46 +0200 From: "Michael S. Tsirkin" Message-ID: <20140220051346.GA28241@redhat.com> References: <1392647087-23020-1-git-send-email-mst@redhat.com> <1392647087-23020-2-git-send-email-mst@redhat.com> <20140217145138.GJ29329@ERROL.INI.CMU.EDU> <20140219135022.GA17601@redhat.com> <20140219190215.GA24591@redhat.com> <20140219194528.GW29329@ERROL.INI.CMU.EDU> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140219194528.GW29329@ERROL.INI.CMU.EDU> Subject: Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: Peter Maydell , qemu-devel@nongnu.org, Anthony Liguori On Wed, Feb 19, 2014 at 02:45:29PM -0500, Gabriel L. Somlo wrote: > On Wed, Feb 19, 2014 at 09:02:15PM +0200, Michael S. Tsirkin wrote: > > On Wed, Feb 19, 2014 at 03:50:22PM +0200, Michael S. Tsirkin wrote: > > > On Mon, Feb 17, 2014 at 09:51:39AM -0500, Gabriel L. Somlo wrote: > > > > With this latest version of your patch, I crash during OS X boot with > > > > "unable to find driver for this platform:\"ACPI\".\n"@/SourceCache/xnu/xnu-2050.48.12/iokit/Kernel/IOPlatformExpert.cpp:1514" > > > > > > > Any chance below helps on top? > > > Another alternative is that DSDT referencing > > > SSDT does not work for apple. > > > I hope it's not that, that would be annoying... > > > > OK I think it's that unfortunately. > > The following on top should help. > > Can you confirm please? > > > > Thanks a lot for the report! > > > > commit a0ad25b1e5d0eb21cbba001799341bd6b557e995 > > Author: Michael S. Tsirkin > > Date: Wed Feb 19 17:20:56 2014 +0200 > > > > Don't call SSDT from DSDT > > > > Windows XP doesn't like this. > > Apparently, neither does Mac OSX. > > > > Signed-off-by: Michael S. Tsirkin > > Tested-by: "Gabriel L. Somlo" > > Sorry, still the same error :( Oh yes, I forgot that Q35 has a separate DSDT. Please add this on top: commit ceb36090bf2054c8ad5c8cf441b690fad5581f4f Author: Michael S. Tsirkin Date: Thu Feb 20 07:10:56 2014 +0200 q35: fix up dsdt as well diff --git a/hw/i386/q35-acpi-dsdt.dsl b/hw/i386/q35-acpi-dsdt.dsl index 8e522a5..f4d2a2d 100644 --- a/hw/i386/q35-acpi-dsdt.dsl +++ b/hw/i386/q35-acpi-dsdt.dsl @@ -72,7 +72,6 @@ DefinitionBlock ( Name(_ADR, 0x00) Name(_UID, 1) -#define ISA SF8_ External(ISA, DeviceObj) // _OSC: based on sample of ACPI3.0b spec @@ -140,8 +139,10 @@ DefinitionBlock ( * LPC ISA bridge ****************************************************************/ - Scope(\_SB.PCI0.ISA) { + Scope(\_SB.PCI0) { /* PCI D31:f0 LPC ISA bridge */ + Device(ISA) { + Name (_ADR, 0x001F0000) // _ADR: Address /* ICH9 PCI to ISA irq remapping */ OperationRegion(PIRQ, PCI_Config, 0x60, 0x0C) @@ -164,6 +165,7 @@ DefinitionBlock ( LPEN, 1, FDEN, 1 } + } } #define DSDT_APPLESMC_STA q35_dsdt_applesmc_sta