From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WGPaq-0000e9-6R
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 04:07:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WGPak-00067y-75
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 04:06:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1WGPaj-00067u-UK
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 04:06:50 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1K96fKT011181
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 20 Feb 2014 04:06:48 -0500
Date: Thu, 20 Feb 2014 10:03:09 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20140220090309.GA3617@dhcp-200-207.str.redhat.com>
References: <1392822778-4823-1-git-send-email-kwolf@redhat.com>
	<8761oa8d6t.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8761oa8d6t.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 0/7] qemu-img: Fix handling of multiply
 specified options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

Am 20.02.2014 um 08:18 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
> > If you specify the same option more than once (e.g. -o cluster_size=4k
> > -o lazy_refcounts=on), qemu-img silently ignores all but the last one. This
> 
> Sounds like perfectly common behavior to me.

I guess it depends on the kind of option. For -o it's no less surprising
than 'gcc -Wall -Werror' giving you only -Werror without -Wall.

> > series fixes it to either consider all options or to give an error message.
> 
> Doesn't this break usage like "Compiled-in default is no good for me,
> create wrapper script setting my defaults followed by "$@", then
> override them on command line"?

It does. Would you be happy with a series that accumulates -o options
(like this one does) and leaves the other options alone?

Kevin