* [Qemu-devel] [PULL] Chardev fix
@ 2014-02-20 10:00 Amit Shah
2014-02-21 14:55 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Amit Shah @ 2014-02-20 10:00 UTC (permalink / raw)
To: qemu list; +Cc: Gal Hammer, peter.maydell, Gerd Hoffmann, Anthony Liguori
Hi,
This fix by Gal Hammer has been on list for quite a while, please pull.
The following changes since commit
46eef33b89e936ca793e13c4aeea1414e97e8dbb:
Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git char-fixes
for you to fetch changes up to
5f9b4bcaefa6ed4c7ce7181bd041d2a5b774bd5e:
char: restore read callback on a reattached (hotplug) chardev
(2014-02-20 15:17:32 +0530)
----------------------------------------------------------------
Gal Hammer (1):
char: restore read callback on a reattached (hotplug) chardev
qemu-char.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
Amit
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PULL] Chardev fix
2014-02-20 10:00 [Qemu-devel] [PULL] Chardev fix Amit Shah
@ 2014-02-21 14:55 ` Peter Maydell
2014-02-24 5:52 ` Amit Shah
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2014-02-21 14:55 UTC (permalink / raw)
To: Amit Shah; +Cc: Gal Hammer, qemu list, Anthony Liguori, Gerd Hoffmann
On 20 February 2014 10:00, Amit Shah <amit.shah@redhat.com> wrote:
> This fix by Gal Hammer has been on list for quite a while, please pull.
>
>
> The following changes since commit
> 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
>
> Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git char-fixes
>
> for you to fetch changes up to
> 5f9b4bcaefa6ed4c7ce7181bd041d2a5b774bd5e:
>
> char: restore read callback on a reattached (hotplug) chardev
> (2014-02-20 15:17:32 +0530)
Sorry, but this fails 'make check':
GTESTER check-qtest-aarch64
qemu-system-aarch64: /root/qemu/qemu-char.c:2517:
tcp_chr_update_read_handler: Assertion `!chr->fd_in_tag' failed.
Broken pipe
(not aarch64-specific either; if you let make continue past
errors it asserts on just about every other softmmu test too).
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PULL] Chardev fix
2014-02-21 14:55 ` Peter Maydell
@ 2014-02-24 5:52 ` Amit Shah
0 siblings, 0 replies; 3+ messages in thread
From: Amit Shah @ 2014-02-24 5:52 UTC (permalink / raw)
To: Peter Maydell; +Cc: Gal Hammer, qemu list, Anthony Liguori, Gerd Hoffmann
On (Fri) 21 Feb 2014 [14:55:48], Peter Maydell wrote:
> On 20 February 2014 10:00, Amit Shah <amit.shah@redhat.com> wrote:
> > This fix by Gal Hammer has been on list for quite a while, please pull.
> >
> >
> > The following changes since commit
> > 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
> >
> > Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git char-fixes
> >
> > for you to fetch changes up to
> > 5f9b4bcaefa6ed4c7ce7181bd041d2a5b774bd5e:
> >
> > char: restore read callback on a reattached (hotplug) chardev
> > (2014-02-20 15:17:32 +0530)
>
> Sorry, but this fails 'make check':
>
> GTESTER check-qtest-aarch64
> qemu-system-aarch64: /root/qemu/qemu-char.c:2517:
> tcp_chr_update_read_handler: Assertion `!chr->fd_in_tag' failed.
> Broken pipe
>
> (not aarch64-specific either; if you let make continue past
> errors it asserts on just about every other softmmu test too).
Sorry about that!
Gal, can you take a look?
Amit
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-24 5:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-20 10:00 [Qemu-devel] [PULL] Chardev fix Amit Shah
2014-02-21 14:55 ` Peter Maydell
2014-02-24 5:52 ` Amit Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).