From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PULL 0/3] qtest: avoid pidfile and QEMU process leaks
Date: Thu, 20 Feb 2014 11:23:37 +0100 [thread overview]
Message-ID: <20140220102337.GE1272@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <5304F69C.8070206@suse.de>
On Wed, Feb 19, 2014 at 07:23:24PM +0100, Andreas Färber wrote:
> Am 19.02.2014 15:50, schrieb Stefan Hajnoczi:
> > Reviewed by Paolo and Markus. Here is the pull request.
> >
> > v2:
> > * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo]
> > * Use sigemptyset() to avoid assumption about signal mask [Markus]
> > * if (fd != -1) close(fd) is no longer necessary [Markus]
> >
> > This series prevents the following qtest issues:
> >
> > 1. Leaking the pidfile if QEMU startup fails, as discovered by Andreas Färber.
> > 2. Leaking the QEMU process when a test case aborts.
> >
> > Applying this series should make buildbots and manual "make check" users have a
> > more pleasant and less leaky experience :).
> >
> > The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
> >
> > Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
> >
> > are available in the git repository at:
> >
> > git://github.com/stefanha/qemu.git tags/qtest-monitor-process-pull-request
> >
> > for you to fetch changes up to b15d422a23a3e4cf1b4195af209211eccdb88d51:
> >
> > qtest: kill QEMU process on g_assert() failure (2014-02-19 15:45:51 +0100)
> >
> > ----------------------------------------------------------------
> > qtest resource cleanup pull request
> >
> > ----------------------------------------------------------------
> > Stefan Hajnoczi (3):
> > qtest: drop unused child_pid field
> > qtest: make QEMU our direct child process
> > qtest: kill QEMU process on g_assert() failure
> >
> > tests/libqtest.c | 59 +++++++++++++++++++++++++-------------------------------
> > 1 file changed, 26 insertions(+), 33 deletions(-)
>
> Ack, my pending pull touches qtest.c rather than libqtest.c (hope you
> remembered to check!) and changes look OK, didn't test yet though.
I took a quick look and don't see any conflicts/issues.
next prev parent reply other threads:[~2014-02-20 10:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 14:50 [Qemu-devel] [PULL 0/3] qtest: avoid pidfile and QEMU process leaks Stefan Hajnoczi
2014-02-19 14:50 ` [Qemu-devel] [PULL 1/3] qtest: drop unused child_pid field Stefan Hajnoczi
2014-02-19 14:50 ` [Qemu-devel] [PULL 2/3] qtest: make QEMU our direct child process Stefan Hajnoczi
2014-02-19 14:50 ` [Qemu-devel] [PULL 3/3] qtest: kill QEMU process on g_assert() failure Stefan Hajnoczi
2014-02-19 18:23 ` [Qemu-devel] [PULL 0/3] qtest: avoid pidfile and QEMU process leaks Andreas Färber
2014-02-20 10:23 ` Stefan Hajnoczi [this message]
2014-02-21 15:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220102337.GE1272@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).