From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WGQnC-0002Bi-Qb
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 05:23:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WGQn7-00046y-E0
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 05:23:46 -0500
Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:40692)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WGQn7-00046m-79
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 05:23:41 -0500
Received: by mail-we0-f181.google.com with SMTP id w61so1313582wes.12
	for <qemu-devel@nongnu.org>; Thu, 20 Feb 2014 02:23:40 -0800 (PST)
Date: Thu, 20 Feb 2014 11:23:37 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140220102337.GE1272@stefanha-thinkpad.redhat.com>
References: <1392821445-4587-1-git-send-email-stefanha@redhat.com>
	<5304F69C.8070206@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5304F69C.8070206@suse.de>
Subject: Re: [Qemu-devel] [PULL 0/3] qtest: avoid pidfile and QEMU process
 leaks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Anthony Liguori <aliguori@amazon.com>

On Wed, Feb 19, 2014 at 07:23:24PM +0100, Andreas Färber wrote:
> Am 19.02.2014 15:50, schrieb Stefan Hajnoczi:
> > Reviewed by Paolo and Markus.  Here is the pull request.
> > 
> > v2:
> >  * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo]
> >  * Use sigemptyset() to avoid assumption about signal mask [Markus]
> >  * if (fd != -1) close(fd) is no longer necessary [Markus]
> > 
> > This series prevents the following qtest issues:
> > 
> > 1. Leaking the pidfile if QEMU startup fails, as discovered by Andreas Färber.
> > 2. Leaking the QEMU process when a test case aborts.
> > 
> > Applying this series should make buildbots and manual "make check" users have a
> > more pleasant and less leaky experience :).
> > 
> > The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
> > 
> >   Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
> > 
> > are available in the git repository at:
> > 
> >   git://github.com/stefanha/qemu.git tags/qtest-monitor-process-pull-request
> > 
> > for you to fetch changes up to b15d422a23a3e4cf1b4195af209211eccdb88d51:
> > 
> >   qtest: kill QEMU process on g_assert() failure (2014-02-19 15:45:51 +0100)
> > 
> > ----------------------------------------------------------------
> > qtest resource cleanup pull request
> > 
> > ----------------------------------------------------------------
> > Stefan Hajnoczi (3):
> >       qtest: drop unused child_pid field
> >       qtest: make QEMU our direct child process
> >       qtest: kill QEMU process on g_assert() failure
> > 
> >  tests/libqtest.c | 59 +++++++++++++++++++++++++-------------------------------
> >  1 file changed, 26 insertions(+), 33 deletions(-)
> 
> Ack, my pending pull touches qtest.c rather than libqtest.c (hope you
> remembered to check!) and changes look OK, didn't test yet though.

I took a quick look and don't see any conflicts/issues.