From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1WGjS2-0002Vz-VF
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 01:19:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1WGjRv-00074Y-7p
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 01:19:10 -0500
Received: from e9.ny.us.ibm.com ([32.97.182.139]:54480)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1WGjRv-00074O-2y
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 01:19:03 -0500
Received: from /spool/local
	by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Fri, 21 Feb 2014 01:19:02 -0500
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <1390832289-18701-1-git-send-email-agraf@suse.de>
References: <1390832289-18701-1-git-send-email-agraf@suse.de>
Message-ID: <20140221061857.20750.48181@loki>
Date: Fri, 21 Feb 2014 00:18:57 -0600
Subject: Re: [Qemu-devel] [PATCH] KVM: Use return value for error print
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>
Cc: gleb@kernel.org, Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-stable@nongnu.org, thomas knych <thomaswk@google.com>

Quoting Alexander Graf (2014-01-27 08:18:09)
> Commit 94ccff13 introduced a more verbose failure message and retry
> operations on KVM VM creation. However, it ended up using a variable
> for its failure message that hasn't been initialized yet.
> =

> Fix it to use the value it meant to set.
> =

> Signed-off-by: Alexander Graf <agraf@suse.de>

ping for 1.7.1

> ---
>  kvm-all.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> =

> diff --git a/kvm-all.c b/kvm-all.c
> index a3fb8de..3f78651 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1427,7 +1427,7 @@ int kvm_init(void)
>      } while (ret =3D=3D -EINTR);
> =

>      if (ret < 0) {
> -        fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -s->vmfd,
> +        fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
>                  strerror(-ret));
> =

>  #ifdef TARGET_S390X
> -- =

> 1.8.1.4