From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGmzM-0006Mv-OM for qemu-devel@nongnu.org; Fri, 21 Feb 2014 05:05:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGmzH-00014c-Uu for qemu-devel@nongnu.org; Fri, 21 Feb 2014 05:05:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGmzH-00014W-FS for qemu-devel@nongnu.org; Fri, 21 Feb 2014 05:05:43 -0500 Date: Fri, 21 Feb 2014 11:05:32 +0100 From: Stefan Hajnoczi Message-ID: <20140221100532.GA17890@stefanha-thinkpad.redhat.com> References: <1392907243-10781-1-git-send-email-v.maffione@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1392907243-10781-1-git-send-email-v.maffione@gmail.com> Subject: Re: [Qemu-devel] [PATCH v2] net: Disable netmap backend when not supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, aliguori@amazon.com, pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it, rth@twiddle.net On Thu, Feb 20, 2014 at 03:40:43PM +0100, Vincenzo Maffione wrote: > This patch fixes configure so that the netmap backend is not compiled in if the > host doesn't support an API version >= 11. A version upper bound (15) has been > added so that the netmap API can be extended with some minor features without > requiring QEMU code modifications. > > Moreover, some changes have been done to net/netmap.c in order to reflect the > current netmap API/ABI (11). > > The NETMAP_WITH_LIBS macro makes possible to include some utilities (e.g. > netmap ring macros, D(), RD() and other high level functions) through the netmap > headers. In this way we get rid of the D and RD macro definitions in the QEMU > code, and we open the way for further code simplifications that will be > introduced by future patches. > > Signed-off-by: Vincenzo Maffione > --- > Note: This patch is against the net-next/net Stefan's branch. > > Changes against the previous version: > (1) more complete commit description > (2) add comment in ./configure to explain version checks > > configure | 10 +++++++++- > net/netmap.c | 55 +++++++++++++------------------------------------------ > 2 files changed, 22 insertions(+), 43 deletions(-) Thanks for adding the explanations, it will make it easier for people reading the code to understand this change in the future. Applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan