From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGycM-0006Vi-Is for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:30:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGycH-0006mD-MG for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:30:50 -0500 Received: from lnantes-156-75-100-125.w80-12.abo.wanadoo.fr ([80.12.84.125]:58667 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGycH-0006m6-8A for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:30:45 -0500 Date: Fri, 21 Feb 2014 23:30:45 +0100 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20140221223045.GB13076@irqsave.net> References: <1393017681-12794-1-git-send-email-benoit.canet@irqsave.net> <1393017681-12794-7-git-send-email-benoit.canet@irqsave.net> <5307CEA6.5050003@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <5307CEA6.5050003@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com The Friday 21 Feb 2014 =E0 15:09:42 (-0700), Eric Blake wrote : > On 02/21/2014 02:21 PM, Beno=EEt Canet wrote: > > From: Beno=EEt Canet > >=20 > > This patchset enables the core of the quorum mechanism. > > The num_children reads are compared to get the majority version and i= f this > > version exists more than threshold times the guest won't see the erro= r at all. >=20 > > +++ b/docs/qmp/qmp-events.txt > > @@ -500,3 +500,39 @@ Example: > > =20 > > Note: If action is "reset", "shutdown", or "pause" the WATCHDOG even= t is > > followed respectively by the RESET, SHUTDOWN, or STOP events. > > + > > +QUORUM_FAILURE > > +-------------- >=20 > This should have been inserted in sorted order to match the rest of the > file, rather than at the end. Can be rearranged in a followup patch, > now that this series is queued. >=20 > > + > > +Emitted by the Quorum block driver if it fails to establish a quorum= . > > + > > +Data: > > + > > +- "reference": device name if defined else node name. > > +- "sector-num": Number of the first sector of the failed read oper= ation. >=20 > I'm assuming sector-num is relative to the guest's view of the data? Yes, >=20 > > + > > +QUORUM_REPORT_BAD > > +----------------- > > + > > +Emitted to report a corruption of a Quorum file. > > + > > +Data: > > + > > +- "ret": The IO return code. >=20 > What values is this likely to contain? Is it a finite set, in which > case it would be nice to have a QAPI enum that describes the set of > return codes, rather than a raw number? It's anything that the block stack could return as an error. >=20 > I'd like to make sure we are happy with the wire format of this QMP > event before it gets baked into 2.0. Ok >=20 > --=20 > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >=20