From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33291)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WGyv0-000254-2v
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:50:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WGyuv-0004aE-1i
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:50:06 -0500
Received: from lnantes-156-75-100-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:58670 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WGyuu-0004a7-Rc
	for qemu-devel@nongnu.org; Fri, 21 Feb 2014 17:50:00 -0500
Date: Fri, 21 Feb 2014 23:50:00 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140221225000.GA13587@irqsave.net>
References: <1393017681-12794-1-git-send-email-benoit.canet@irqsave.net>
	<1393017681-12794-7-git-send-email-benoit.canet@irqsave.net>
	<5307CEA6.5050003@redhat.com> <20140221223045.GB13076@irqsave.net>
	<20140221223809.GI3346@dhcp-200-207.str.redhat.com>
	<5307D6B6.3050108@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5307D6B6.3050108@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V19 06/12] quorum: Add quorum mechanism.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

The Friday 21 Feb 2014 =E0 15:44:06 (-0700), Eric Blake wrote :
> On 02/21/2014 03:38 PM, Kevin Wolf wrote:
> >>>> +- "ret":          The IO return code.
> >>>
> >>> What values is this likely to contain?  Is it a finite set, in whic=
h
> >>> case it would be nice to have a QAPI enum that describes the set of
> >>> return codes, rather than a raw number?
> >>
> >> It's anything that the block stack could return as an error.
> >=20
> > In other words, it's meaning depends on the host and the value is onl=
y
> > suitable for human readers. Perhaps we could change this to strerror(=
),
> > which is, I believe, the same as error_setg_errno() does.
>=20
> Ah, so you're saying that 'ret' would be a '-errno' value - in that
> case, yes, converting it to string, and documenting this field as a
> human-only strerror() representation of the error would also work (usin=
g
> 'str', rather than an enum type).

How do I proceed ?

Should I respin the serie ? Or do a follow up patch ?=20

>=20
> --=20
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20