From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55462)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WHF0J-00004u-HQ
	for qemu-devel@nongnu.org; Sat, 22 Feb 2014 11:00:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WHF0D-0007PT-61
	for qemu-devel@nongnu.org; Sat, 22 Feb 2014 11:00:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1WHF0C-0007PE-VR
	for qemu-devel@nongnu.org; Sat, 22 Feb 2014 11:00:33 -0500
Date: Sun, 23 Feb 2014 00:00:38 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140222160038.GB16767@T430.redhat.com>
References: <1393032048-17982-1-git-send-email-benoit.canet@irqsave.net>
	<1393032048-17982-4-git-send-email-benoit.canet@irqsave.net>
	<20140222073815.GA16767@T430.redhat.com>
	<20140222115806.GA3245@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20140222115806.GA3245@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 3/3] qemu-io-test: Disable Quorum test
 when not compiled in.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

On Sat, 02/22 12:58, Beno=EEt Canet wrote:
> The Saturday 22 Feb 2014 =E0 15:38:15 (+0800), Fam Zheng wrote :
> > On Sat, 02/22 02:20, Beno=EEt Canet wrote:
> > > Quorum is not compiled by default: make the quorum 081 test aware o=
f this.
> > >=20
> > > Signed-off-by: Benoit Canet <benoit@irqsave.net>
> > > ---
> > >  tests/qemu-iotests/081 | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >=20
> > > diff --git a/tests/qemu-iotests/081 b/tests/qemu-iotests/081
> > > index f053f11..c1078f6 100755
> > > --- a/tests/qemu-iotests/081
> > > +++ b/tests/qemu-iotests/081
> > > @@ -56,6 +56,9 @@ function run_qemu()
> > >      do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_qmp | _filte=
r_qemu_io
> > >  }
> > > =20
> > > +test_quorum=3D$(qemu-img --help|grep quorum)
> > > +[ "$test_quorum" =3D "" ] && _supported_fmt quorum
> > > +
> >=20
> > How does this disable the test? When quorum is not compiled, the two =
lines are
> > no-op. Did you test it?
>=20
> Yes I did test it. It works.
>=20

Yes, I read it wrong, it should overwrite raw with quorum, so it works.

Still, qemu-img should be written $QEMU_IMG.

Thanks,
Fam