From: Amit Shah <amit.shah@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gal Hammer <ghammer@redhat.com>,
qemu list <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PULL] Chardev fix
Date: Mon, 24 Feb 2014 11:22:13 +0530 [thread overview]
Message-ID: <20140224055213.GA5289@grmbl.mre> (raw)
In-Reply-To: <CAFEAcA_dYVummfK6JYFxzRpjxJDhCqXh4U734FsTzTetnyD0sA@mail.gmail.com>
On (Fri) 21 Feb 2014 [14:55:48], Peter Maydell wrote:
> On 20 February 2014 10:00, Amit Shah <amit.shah@redhat.com> wrote:
> > This fix by Gal Hammer has been on list for quite a while, please pull.
> >
> >
> > The following changes since commit
> > 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
> >
> > Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git char-fixes
> >
> > for you to fetch changes up to
> > 5f9b4bcaefa6ed4c7ce7181bd041d2a5b774bd5e:
> >
> > char: restore read callback on a reattached (hotplug) chardev
> > (2014-02-20 15:17:32 +0530)
>
> Sorry, but this fails 'make check':
>
> GTESTER check-qtest-aarch64
> qemu-system-aarch64: /root/qemu/qemu-char.c:2517:
> tcp_chr_update_read_handler: Assertion `!chr->fd_in_tag' failed.
> Broken pipe
>
> (not aarch64-specific either; if you let make continue past
> errors it asserts on just about every other softmmu test too).
Sorry about that!
Gal, can you take a look?
Amit
prev parent reply other threads:[~2014-02-24 5:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 10:00 [Qemu-devel] [PULL] Chardev fix Amit Shah
2014-02-21 14:55 ` Peter Maydell
2014-02-24 5:52 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224055213.GA5289@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=ghammer@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).