From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40266)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1WHoSo-0004rb-2Z
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 00:52:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1WHoSi-00083q-3R
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 00:52:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1WHoSh-00083h-Ro
	for qemu-devel@nongnu.org; Mon, 24 Feb 2014 00:52:20 -0500
Date: Mon, 24 Feb 2014 11:22:13 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20140224055213.GA5289@grmbl.mre>
References: <20140220100038.GA7585@grmbl.mre>
	<CAFEAcA_dYVummfK6JYFxzRpjxJDhCqXh4U734FsTzTetnyD0sA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_dYVummfK6JYFxzRpjxJDhCqXh4U734FsTzTetnyD0sA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PULL] Chardev fix
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gal Hammer <ghammer@redhat.com>, qemu list <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Gerd Hoffmann <kraxel@redhat.com>

On (Fri) 21 Feb 2014 [14:55:48], Peter Maydell wrote:
> On 20 February 2014 10:00, Amit Shah <amit.shah@redhat.com> wrote:
> > This fix by Gal Hammer has been on list for quite a while, please pull.
> >
> >
> > The following changes since commit
> > 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
> >
> >   Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/qemu/amit/virtio-serial.git  char-fixes
> >
> > for you to fetch changes up to
> > 5f9b4bcaefa6ed4c7ce7181bd041d2a5b774bd5e:
> >
> >   char: restore read callback on a reattached (hotplug) chardev
> >   (2014-02-20 15:17:32 +0530)
> 
> Sorry, but this fails 'make check':
> 
> GTESTER check-qtest-aarch64
> qemu-system-aarch64: /root/qemu/qemu-char.c:2517:
> tcp_chr_update_read_handler: Assertion `!chr->fd_in_tag' failed.
> Broken pipe
> 
> (not aarch64-specific either; if you let make continue past
> errors it asserts on just about every other softmmu test too).

Sorry about that!

Gal, can you take a look?

		Amit