From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes
Date: Mon, 24 Feb 2014 19:33:11 +0800 [thread overview]
Message-ID: <20140224113311.GA24100@T430.redhat.com> (raw)
In-Reply-To: <530B216C.5050902@redhat.com>
On Mon, 02/24 11:39, Paolo Bonzini wrote:
> Il 24/02/2014 02:01, Fam Zheng ha scritto:
> >
> >I would do this in qcow2:
> >
> > 1. In qcow2_co_writev, allocate cluster regardless of if data is zero or not.
> > 2. If data is zero, set QCOW2_OFLAG_ZERO in L2.
>
> This is (or should be) bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP.
But IIUC bdrv_co_write_zeroes without BDRV_REQ_MAY_UNMAP doesn't require
cluster allocation if it's allocated yet, which is a bit different.
Fam
next prev parent reply other threads:[~2014-02-24 11:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 13:00 [Qemu-devel] [RFC PATCH] block: optimize zero writes with bdrv_write_zeroes Peter Lieven
2014-02-22 16:45 ` Fam Zheng
2014-02-23 19:10 ` Peter Lieven
2014-02-24 1:01 ` Fam Zheng
2014-02-24 10:39 ` Paolo Bonzini
2014-02-24 11:33 ` Fam Zheng [this message]
2014-02-24 11:51 ` Paolo Bonzini
2014-02-24 12:04 ` Fam Zheng
2014-02-24 12:07 ` Kevin Wolf
2014-02-24 12:10 ` Paolo Bonzini
2014-02-24 12:22 ` Kevin Wolf
2014-02-24 10:11 ` Kevin Wolf
2014-02-24 10:26 ` Peter Lieven
2014-02-24 10:38 ` Paolo Bonzini
2014-02-24 11:50 ` Peter Lieven
2014-02-24 13:01 ` Peter Lieven
2014-02-25 13:41 ` Kevin Wolf
2014-02-25 17:03 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224113311.GA24100@T430.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).