qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Luke Gorrie <luke@snabb.co>
Cc: "snabb-devel@googlegroups.com" <snabb-devel@googlegroups.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Make virtio-net.c ring size configurable?
Date: Mon, 24 Feb 2014 16:20:04 +0100	[thread overview]
Message-ID: <20140224152004.GC23185@stefanha-thinkpad.hitronhub.home> (raw)
In-Reply-To: <CAA2XHbddwSHVrbiYWQJEE0OiQMxrLPsahjJHZwUP31G+N1E4ig@mail.gmail.com>

On Fri, Feb 14, 2014 at 02:43:14PM +0100, Luke Gorrie wrote:
> Observation: virtio-net.c hard-codes the vring size to 256 buffers.
> 
> Could this reasonably be made configurable, or would that be likely to
> cause a problem?
> 
> In Snabb Switch we are creating a 1:1 mapping between Virtio-net
> descriptors and VMDq hardware receive descriptors. The VMDq queues support
> 32768 buffers and I'd like to match this on the QEMU/Virtio-net side -- or
> at least come close.

In reality virtio-net can use many more buffers because it has the
VIRTIO_RING_F_INDIRECT_DESC feature.  Each descriptor can point to a
whole new descriptor table.

Do you want the 1:1 mapping to achieve best performance or just to
simplify the coding?

Since vhost_net does many Gbit/s I doubt the ring size is a limiting
factor although there are still periodic discussions about tweaking the
direct vs indirect descriptor heuristic.

Stefan

  parent reply	other threads:[~2014-02-24 15:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14 13:43 [Qemu-devel] Make virtio-net.c ring size configurable? Luke Gorrie
2014-02-14 19:34 ` Mario Smarduch
2014-02-24 15:20 ` Stefan Hajnoczi [this message]
2014-02-24 16:14   ` [Qemu-devel] [snabb-devel] " Luke Gorrie
2014-02-27 14:17     ` Stefan Hajnoczi
2014-02-27 14:49       ` Michael S. Tsirkin
2014-02-28  8:02         ` Luke Gorrie
2014-02-24 19:16   ` Luke Gorrie
2016-05-12 17:38 ` [Qemu-devel] " xchenum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140224152004.GC23185@stefanha-thinkpad.hitronhub.home \
    --to=stefanha@gmail.com \
    --cc=luke@snabb.co \
    --cc=qemu-devel@nongnu.org \
    --cc=snabb-devel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).