From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qmp: Check for returned data from __json_read in get_events
Date: Mon, 24 Feb 2014 19:21:29 +0100 [thread overview]
Message-ID: <20140224182129.GK23185@stefanha-thinkpad.hitronhub.home> (raw)
In-Reply-To: <1393220701-27172-1-git-send-email-famz@redhat.com>
On Mon, Feb 24, 2014 at 01:45:01PM +0800, Fam Zheng wrote:
> When QEMU process aborts and socket is closed, qmp client will not
> detect it. When this happens, some qemu-iotests scripts will enter an
> endless loop waiting for qmp events.
>
> It's better we raise an exception in qmp.py to catch this and make the
> test script stop.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> scripts/qmp/qmp.py | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2014-02-24 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 5:45 [Qemu-devel] [PATCH] qmp: Check for returned data from __json_read in get_events Fam Zheng
2014-02-24 18:21 ` Stefan Hajnoczi [this message]
2014-02-28 18:36 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224182129.GK23185@stefanha-thinkpad.hitronhub.home \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).