From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIF41-0007GV-OD for qemu-devel@nongnu.org; Tue, 25 Feb 2014 05:16:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIF3w-0000d7-E9 for qemu-devel@nongnu.org; Tue, 25 Feb 2014 05:16:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIF3w-0000cf-7C for qemu-devel@nongnu.org; Tue, 25 Feb 2014 05:16:32 -0500 Date: Tue, 25 Feb 2014 11:16:16 +0100 From: Kevin Wolf Message-ID: <20140225101616.GB3339@dhcp-200-207.str.redhat.com> References: <1393322998-10289-1-git-send-email-stefanha@redhat.com> <1393322998-10289-4-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1393322998-10289-4-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: add 080 NBD client disconnect tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Paolo Bonzini , nick@bytemark.co.uk, qemu-devel@nongnu.org, bluewindow@h3c.com Am 25.02.2014 um 11:09 hat Stefan Hajnoczi geschrieben: > This new test case uses nbd-fault-injector.py to simulate broken TCP > connections at each stage in the NBD protocol. This way we can exercise > block/nbd-client.c's socket error handling code paths. > > In particular, this serves as a regression test to make sure > nbd-client.c doesn't cause an infinite loop by leaving its > nbd_receive_reply() fd handler registered after the connection has been > closed. This bug was fixed in an earlier patch. > > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/080 | 91 ++++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/080.out | 73 +++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + 083 is the next free one, afaik. (081 and 082 are used by the pull request I sent on Friday, and I think 080 was reserved for some series, but I don't remember who it was.) Kevin