From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIFa2-0002eE-LL for qemu-devel@nongnu.org; Tue, 25 Feb 2014 05:49:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIFZw-000554-ME for qemu-devel@nongnu.org; Tue, 25 Feb 2014 05:49:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIFZw-00054L-F4 for qemu-devel@nongnu.org; Tue, 25 Feb 2014 05:49:36 -0500 Date: Tue, 25 Feb 2014 11:49:24 +0100 From: Stefan Hajnoczi Message-ID: <20140225104924.GA11538@stefanha-thinkpad.redhat.com> References: <1388942528-10453-1-git-send-email-pl@kamp.de> <20140224125457.GB15488@stefanha-thinkpad.redhat.com> <530BA9D2.30008@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <530BA9D2.30008@kamp.de> Subject: Re: [Qemu-devel] [PATCHv2 00/18] qemu-iotests: adjust tests to work with the NFS protocol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi , Jeff Cody , qemu-devel@nongnu.org, Max Reitz , owasserm@redhat.com, Federico Simoncelli , ronniesahlberg@gmail.com, Wenchao Xia On Mon, Feb 24, 2014 at 09:21:38PM +0100, Peter Lieven wrote: > Am 24.02.2014 13:54, schrieb Stefan Hajnoczi: > > On Sun, Jan 05, 2014 at 06:21:50PM +0100, Peter Lieven wrote: > >> In order to proceed with the integration of the NFS protocol driver into > >> qemu I was asked by Stefan to add integration for NFS into the qemu-iotests. > >> > >> Unfortunately, this became more complex than I had expected because most > >> of the tests for non RAW formats only work with the file protocol because > >> they use shell commands like cp, rm or mv which obviously don't work > >> on nfs:// URLs. > >> > >> This series first changes all those tests that are not working out of the > >> box to support only the file protocol. > >> > >> After the NFS protocol is introduced in Patch 2 I fix most of them > >> to work with any protocol. > >> > >> After this series the qemu-iotests for NFS run through gracefully with > >> the RAW, QCOW2 and VMDK formats. > >> > >> There are 3 topics open: > >> - test 051 fails regardless which protocol is used (I already send a msg > >> to the list) > >> - test 052 should work, but it seems there is a bug in the bdrv_open > >> logic if the BDRV_O_SNAPSHOT flag is set and the protocol is anything > >> else than file. Maybe someone with more understanding of the whole > >> open logic could look at this. I do not believe that its sth which > >> has to do with the NFS driver since the test fails while opening the > >> backing file and other backing file tests run without problems. > >> - other protocols like sheepdog or ssh that are allowed to use other formats > >> than raw should be tested. they actually can't never have run qemu-iotests > >> with qcow2 protocol for instance. > >> > >> If you want to do your tests please make sure to have > >> [PATCHv5] block: add native support for NFS > >> [PATCH v2] vmdk: Allow vmdk_create to work with protocol > > Going through my email backlog. What is the status of this series? > The NFS driver and bare qemu-iotests support is merged. All the patches > that try to fix the limit for protocol != file where left out because there > was no consensus how the filename construction etc. should be handled. Okay, it's the latter I was wondering about. Let's leave it for now. Stefan