From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIfwl-0008Jn-Jl for qemu-devel@nongnu.org; Wed, 26 Feb 2014 09:59:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIfwd-0004il-24 for qemu-devel@nongnu.org; Wed, 26 Feb 2014 09:58:55 -0500 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:37934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIfwc-0004ie-R4 for qemu-devel@nongnu.org; Wed, 26 Feb 2014 09:58:46 -0500 Received: by mail-we0-f174.google.com with SMTP id t60so359465wes.33 for ; Wed, 26 Feb 2014 06:58:45 -0800 (PST) Date: Wed, 26 Feb 2014 15:58:40 +0100 From: Stefan Hajnoczi Message-ID: <20140226145840.GA19713@stefanha-thinkpad.muc.redhat.com> References: <3a11a1884b2f90c0ab9138edc86bad0c283a3e4e.1392653229.git.jcody@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3a11a1884b2f90c0ab9138edc86bad0c283a3e4e.1392653229.git.jcody@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/2] block: gluster - code movements, state storage changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, benoit.canet@irqsave.net, qemu-devel@nongnu.org, stefanha@redhat.com, bharata@linux.vnet.ibm.com On Mon, Feb 17, 2014 at 11:11:11AM -0500, Jeff Cody wrote: > In preparation for supporting reopen on gluster, move flag > parsing out to a function. Also, store open_flags and filename > in the gluster state storage struct, and add a NULL check in the > gconf cleanup. It no longer stores open_flags and filename in the gluster state storage struct. I can fix this up when merging.