From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47011)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WIg2k-0003L3-PU
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 10:05:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WIg2c-0007SW-C6
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 10:05:06 -0500
Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:59696)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WIg2c-0007SJ-48
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 10:04:58 -0500
Received: by mail-wi0-f177.google.com with SMTP id e4so2244872wiv.16
	for <qemu-devel@nongnu.org>; Wed, 26 Feb 2014 07:04:57 -0800 (PST)
Date: Wed, 26 Feb 2014 16:04:53 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140226150453.GB19713@stefanha-thinkpad.muc.redhat.com>
References: <cover.1392653229.git.jcody@redhat.com>
	<a3dd95f264d3d53af7d4026b0da175ce08aa0355.1392653229.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a3dd95f264d3d53af7d4026b0da175ce08aa0355.1392653229.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] block: gluster - add reopen support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, benoit.canet@irqsave.net, qemu-devel@nongnu.org, stefanha@redhat.com, bharata@linux.vnet.ibm.com

On Mon, Feb 17, 2014 at 11:11:12AM -0500, Jeff Cody wrote:
> +static int qemu_gluster_reopen_prepare(BDRVReopenState *state,
> +                                       BlockReopenQueue *queue, Error **errp)
> +{
> +    int ret = 0;
> +    BDRVGlusterReopenState *reop_s;
> +    GlusterConf *gconf = NULL;
> +    int open_flags = 0;
> +
> +    assert(state != NULL);
> +    assert(state->bs != NULL);
> +
> +    state->opaque = g_malloc0(sizeof(BDRVGlusterReopenState));

Not worth respinning but if you use the type name, then the more concise
notation is:

state->opaque = g_new0(BDRVGlusterReopenState, 1);