From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents
Date: Thu, 27 Feb 2014 11:06:28 +0100 [thread overview]
Message-ID: <20140227100628.GB30387@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20140226101731.GA5760@T430.nay.redhat.com>
On Wed, Feb 26, 2014 at 06:17:31PM +0800, Fam Zheng wrote:
> On Wed, 02/26 10:47, Peter Lieven wrote:
> > Signed-off-by: Peter Lieven <pl@kamp.de>
> > ---
> > block/vmdk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/block/vmdk.c b/block/vmdk.c
> > index ff6f5ee..5fa29b0 100644
> > --- a/block/vmdk.c
> > +++ b/block/vmdk.c
> > @@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs,
> > break;
> > case VMDK_OK:
> > ret = BDRV_BLOCK_DATA;
> > - if (extent->file == bs->file) {
> > + if (extent->file == bs->file && !extent->compressed) {
> > ret |= BDRV_BLOCK_OFFSET_VALID | offset;
> > }
> >
> > --
> > 1.7.9.5
> >
>
> Reviewed-by: Fam Zheng <famz@redhat.com>
I don't have the original mail :(. Did it get sent out the mailing
list?
All patches must be posted to qemu-devel@nongnu.org so they can be
reviewed by the community before being merged. Please send top-level
mails, don't send new patches as a reply to another thread.
Stefan
next prev parent reply other threads:[~2014-02-27 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1393408077-556-1-git-send-email-pl@kamp.de>
2014-02-26 10:17 ` [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents Fam Zheng
2014-02-27 10:06 ` Stefan Hajnoczi [this message]
2014-02-27 10:15 ` Peter Lieven
2014-02-27 15:49 ` Stefan Hajnoczi
2014-02-27 10:15 Peter Lieven
2014-02-28 10:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227100628.GB30387@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).