From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIxrR-0005Ac-LB for qemu-devel@nongnu.org; Thu, 27 Feb 2014 05:06:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIxrM-0002lD-Lx for qemu-devel@nongnu.org; Thu, 27 Feb 2014 05:06:37 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:32995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIxrM-0002l5-FF for qemu-devel@nongnu.org; Thu, 27 Feb 2014 05:06:32 -0500 Received: by mail-wi0-f182.google.com with SMTP id f8so3239393wiw.15 for ; Thu, 27 Feb 2014 02:06:31 -0800 (PST) Date: Thu, 27 Feb 2014 11:06:28 +0100 From: Stefan Hajnoczi Message-ID: <20140227100628.GB30387@stefanha-thinkpad.redhat.com> References: <1393408077-556-1-git-send-email-pl@kamp.de> <20140226101731.GA5760@T430.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140226101731.GA5760@T430.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, Peter Lieven , qemu-devel@nongnu.org, stefanha@redhat.com On Wed, Feb 26, 2014 at 06:17:31PM +0800, Fam Zheng wrote: > On Wed, 02/26 10:47, Peter Lieven wrote: > > Signed-off-by: Peter Lieven > > --- > > block/vmdk.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/block/vmdk.c b/block/vmdk.c > > index ff6f5ee..5fa29b0 100644 > > --- a/block/vmdk.c > > +++ b/block/vmdk.c > > @@ -1146,7 +1146,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriverState *bs, > > break; > > case VMDK_OK: > > ret = BDRV_BLOCK_DATA; > > - if (extent->file == bs->file) { > > + if (extent->file == bs->file && !extent->compressed) { > > ret |= BDRV_BLOCK_OFFSET_VALID | offset; > > } > > > > -- > > 1.7.9.5 > > > > Reviewed-by: Fam Zheng I don't have the original mail :(. Did it get sent out the mailing list? All patches must be posted to qemu-devel@nongnu.org so they can be reviewed by the community before being merged. Please send top-level mails, don't send new patches as a reply to another thread. Stefan