From: Stefan Hajnoczi <stefanha@gmail.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu list <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot
Date: Thu, 27 Feb 2014 11:18:15 +0100 [thread overview]
Message-ID: <20140227101815.GC30387@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <155481d240779c5d25f8195a406d57db613507bc.1393407651.git.amit.shah@redhat.com>
On Wed, Feb 26, 2014 at 03:12:37PM +0530, Amit Shah wrote:
> If TMPDIR is not specified, the default was to use /tmp for the working
> copy of the block devices. Update this to /var/tmp instead, so systems
> using tmp-on-tmpfs don't end up inadvertently using RAM for the block
> device.
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> ---
> block.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Was expecting someone to argue against this because a path change is
always controversial :-). But I think this makes sense and no one is
protesting....
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
next prev parent reply other threads:[~2014-02-27 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 9:42 [Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot Amit Shah
2014-02-27 10:18 ` Stefan Hajnoczi [this message]
2014-02-27 11:33 ` Amit Shah
2014-02-27 13:42 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227101815.GC30387@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=amit.shah@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).