From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57340)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WJ1f7-0006Hk-VI
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 09:10:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WJ1ez-0002Xs-IH
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 09:10:09 -0500
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:34069)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WJ1ez-0002Xa-9q
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 09:10:01 -0500
Received: by mail-wg0-f42.google.com with SMTP id x13so2899105wgg.1
	for <qemu-devel@nongnu.org>; Thu, 27 Feb 2014 06:10:00 -0800 (PST)
Date: Thu, 27 Feb 2014 15:09:57 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140227140957.GF30387@stefanha-thinkpad.redhat.com>
References: <cover.1392102900.git.hutao@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1392102900.git.hutao@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH v5 RESEND 0/4] qemu-img: add
	preallocation=full
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org

On Tue, Feb 11, 2014 at 03:07:06PM +0800, Hu Tao wrote:
> This series implements full image preallocation to create a non-sparse image
> file at creation time, both for raw and qcow2 format. The purpose is to avoid
> performance deterioration of the guest cause by sparse image.
> 
> v5:
>   - fix wrong calculation of qcow2 metadata size in v4
>   - remove raw_preallocate2()
>   - better error out path in raw_create()
>   - fix coding style
> 
> 
> Hu Tao (4):
>   qapi: introduce PreallocMode and a new PreallocMode full.
>   raw, qcow2: don't convert file size to sector size
>   raw-posix: Add full image preallocation option
>   qcow2: Add full image preallocation option
> 
>  block/qcow2.c     | 91 ++++++++++++++++++++++++++++++++++++++++++++++++-------
>  block/raw-posix.c | 45 +++++++++++++++++++++------
>  qapi-schema.json  | 12 ++++++++
>  3 files changed, 128 insertions(+), 20 deletions(-)

Besides the comments that have been made, looks good.  The metadata size
calculation is correct now.