From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52790)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1WJ3GJ-0001Ds-Jo
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 10:52:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1WJ3GE-0006ez-Q6
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 10:52:39 -0500
Sender: fluxion <flukshun@gmail.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <1393325096-8338-2-git-send-email-pbonzini@redhat.com>
References: <1393325096-8338-1-git-send-email-pbonzini@redhat.com>
	<1393325096-8338-2-git-send-email-pbonzini@redhat.com>
Message-ID: <20140227155231.28890.28800@loki>
Date: Thu, 27 Feb 2014 09:52:31 -0600
Subject: Re: [Qemu-devel] [Qemu-stable] [PULL 1/1] KVM: Use return value for
	error print
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Alexander Graf <agraf@suse.de>, qemu-stable@nongnu.org

Quoting Paolo Bonzini (2014-02-25 04:44:56)
> From: Alexander Graf <agraf@suse.de>
> =

> Commit 94ccff13 introduced a more verbose failure message and retry
> operations on KVM VM creation. However, it ended up using a variable
> for its failure message that hasn't been initialized yet.
> =

> Fix it to use the value it meant to set.
> =

> Cc: qemu-stable@nongnu.org
> Signed-off-by: Alexander Graf <agraf@suse.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Ping: last call for 1.7.1 (freeze today)

> ---
>  kvm-all.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> =

> diff --git a/kvm-all.c b/kvm-all.c
> index f742f8d..979a8d9 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1427,7 +1427,7 @@ int kvm_init(void)
>      } while (ret =3D=3D -EINTR);
> =

>      if (ret < 0) {
> -        fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -s->vmfd,
> +        fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
>                  strerror(-ret));
> =

>  #ifdef TARGET_S390X
> -- =

> 1.7.1