From: Jeff Cody <jcody@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before recursing
Date: Thu, 27 Feb 2014 17:50:23 -0500 [thread overview]
Message-ID: <20140227225023.GF4165@localhost.localdomain> (raw)
In-Reply-To: <1393539728-27389-1-git-send-email-pbonzini@redhat.com>
On Thu, Feb 27, 2014 at 11:22:08PM +0100, Paolo Bonzini wrote:
> block-obj-y is not anymore part of common-obj-y, because "nesting"
> variables is complicated and requires specifying the correct
> ordering in the calls to unnest-vars. However, because of this
> we need to specify block-obj-y in the dependencies of the
> target subdirectories.
>
> Thanks to Stefan Weil and Jeff Cody for suggesting the cause of
> the regression.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index a443cd4..3938b6c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -167,7 +167,7 @@ subdir-dtc:dtc/libfdt dtc/tests
> dtc/%:
> mkdir -p $@
>
> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)
>
> ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))
> romsubdir-%:
> --
> 1.8.5.3
>
>
Reviewed-by: Jeff Cody <jcody@redhat.com>
next prev parent reply other threads:[~2014-02-27 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 22:22 [Qemu-devel] [PATCH] build: build block-obj-y explicitly before recursing Paolo Bonzini
2014-02-27 22:50 ` Jeff Cody [this message]
2014-02-28 5:27 ` Stefan Weil
2014-02-28 5:49 ` Stefan Weil
2014-02-28 10:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227225023.GF4165@localhost.localdomain \
--to=jcody@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).