From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52776)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1WJ9mk-0005WH-Pk
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:50:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1WJ9me-0000p1-Sh
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:50:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1WJ9me-0000ov-KA
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:50:28 -0500
Date: Thu, 27 Feb 2014 17:50:23 -0500
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20140227225023.GF4165@localhost.localdomain>
References: <1393539728-27389-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1393539728-27389-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before
 recursing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

On Thu, Feb 27, 2014 at 11:22:08PM +0100, Paolo Bonzini wrote:
> block-obj-y is not anymore part of common-obj-y, because "nesting"
> variables is complicated and requires specifying the correct
> ordering in the calls to unnest-vars.  However, because of this
> we need to specify block-obj-y in the dependencies of the
> target subdirectories.
> 
> Thanks to Stefan Weil and Jeff Cody for suggesting the cause of
> the regression.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index a443cd4..3938b6c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -167,7 +167,7 @@ subdir-dtc:dtc/libfdt dtc/tests
>  dtc/%:
>  	mkdir -p $@
>  
> -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y)
> +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y)
>  
>  ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))
>  romsubdir-%:
> -- 
> 1.8.5.3
> 
>

Reviewed-by: Jeff Cody <jcody@redhat.com>