qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
	qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v4 3/6] iothread: add I/O thread object
Date: Fri, 28 Feb 2014 11:39:58 +0100	[thread overview]
Message-ID: <20140228103958.GF30385@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20140226110019.07728967@nial.usersys.redhat.com>

On Wed, Feb 26, 2014 at 11:00:19AM +0100, Igor Mammedov wrote:
> On Fri, 21 Feb 2014 15:46:55 +0100
> Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > +char *iothread_get_id(IOThread *iothread)
> > +{
> > +    /* The last path component is the identifier */
> > +    char *path = object_get_canonical_path(OBJECT(iothread));
> > +    char *id = g_strdup(&path[sizeof(IOTHREADS_PATH)]);
> > +    g_free(path);
> > +    return id;
> > +}
> it seems to be a more generic issue, i.e. QOM object wanting to know its
> name. I've did something similar for memory_backend except of cutting
> of parent's path.
> Could we make and use a more generic accessor for object name?

Yes, I think we can do it in object.c.  Will send another revision.

Stefan

  reply	other threads:[~2014-02-28 11:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 14:46 [Qemu-devel] [PATCH v4 0/6] dataplane: switch to N:M devices-per-thread model Stefan Hajnoczi
2014-02-21 14:46 ` [Qemu-devel] [PATCH v4 1/6] rfifolock: add recursive FIFO lock Stefan Hajnoczi
2014-02-21 14:46 ` [Qemu-devel] [PATCH v4 2/6] aio: add aio_context_acquire() and aio_context_release() Stefan Hajnoczi
2014-02-21 14:46 ` [Qemu-devel] [PATCH v4 3/6] iothread: add I/O thread object Stefan Hajnoczi
2014-02-26 10:00   ` Igor Mammedov
2014-02-28 10:39     ` Stefan Hajnoczi [this message]
2014-02-21 14:46 ` [Qemu-devel] [PATCH v4 4/6] qdev: add get_pointer_and_free() for temporary strings Stefan Hajnoczi
2014-02-26  9:53   ` Igor Mammedov
2014-02-28 10:41     ` Stefan Hajnoczi
2014-02-21 14:46 ` [Qemu-devel] [PATCH v4 5/6] iothread: add "iothread" qdev property type Stefan Hajnoczi
2014-02-21 14:46 ` [Qemu-devel] [PATCH v4 6/6] dataplane: replace internal thread with IOThread Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140228103958.GF30385@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=famz@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).