Re: [Qemu-devel] [PATCH v3 3/6] qemu-img convert: Support multiple -o options

[Kevin Wolf <kwolf@redhat.com>]

Am 03.03.2014 um 12:43 hat Peter Lieven geschrieben:
> On 21.02.2014 16:24, Kevin Wolf wrote:
> >Instead of ignoring all option values but the last one, multiple -o
> >options now have the same meaning as having a single option with all
> >settings in the order of their respective -o options.
> >
> >Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> >---
> >  qemu-img.c | 34 +++++++++++++++++++++++++---------
> >  1 file changed, 25 insertions(+), 9 deletions(-)
> >
> >diff --git a/qemu-img.c b/qemu-img.c
> >index 9c1643d..3fd2168 100644
> >--- a/qemu-img.c
> >+++ b/qemu-img.c
> >@@ -1164,6 +1164,9 @@ static int img_convert(int argc, char **argv)
> >      Error *local_err = NULL;
> >      QemuOpts *sn_opts = NULL;
> >+    /* Initialize before goto out */
> >+    qemu_progress_init(progress, 1.0);
> >+
> moving this up here breaks progrss output because progress is always false
> at this point.

Meh. You're right, of course, this was a stupid one.

I wonder if -p output is consistent enough that we can make a
qemu-iotests case for it. At the moment I can't see a reason why it
wouldn't be consistent.

Kevin