Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle temporary strings

[Igor Mammedov <imammedo@redhat.com>]

On Mon, 3 Mar 2014 10:41:30 +0100
Stefan Hajnoczi <stefanha@redhat.com> wrote:

> On Fri, Feb 28, 2014 at 05:49:09PM +0100, Andreas Färber wrote:
> > Am 28.02.2014 16:18, schrieb Stefan Hajnoczi:
> > > From: Igor Mammedov <imammedo@redhat.com>
> > > 
> > > get_pointer()'s print() callback might return a heap allocated
> > > string, to avoid adding dedicated get_pointer_foo for this case
> > > convert current print() callbacks to return temporary heap
> > > allocated string and make get_pointer() free it.
> > > 
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > > ---
> > >  hw/core/qdev-properties-system.c | 19 +++++++++++--------
> > >  1 file changed, 11 insertions(+), 8 deletions(-)
> > 
> > Not aware of the history of this patch (not CC'ed?) but looks okay,
> > 
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> > 
> > Do we have any users outside of this series?
> 
> The patch comes from Igor originally so maybe he has future patches that
> will use it.
>
> Stefan

I don't have other users/plans to use it.
Patch was suggested as alternative to adding a new API:
 http://lists.gnu.org/archive/html/qemu-devel/2014-02/msg04704.html