From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WKSEI-0001T5-Eq
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 07:44:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WKSEE-0008G6-3z
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 07:44:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:64060)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WKSED-0008G0-Sa
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 07:44:18 -0500
Date: Mon, 3 Mar 2014 13:43:09 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140303134309.2f04b9e8@nial.usersys.redhat.com>
In-Reply-To: <20140303094130.GE4780@stefanha-thinkpad.redhat.com>
References: <1393600696-24118-1-git-send-email-stefanha@redhat.com>
	<1393600696-24118-6-git-send-email-stefanha@redhat.com>
	<5310BE05.2060002@suse.de>
	<20140303094130.GE4780@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 5/7] qdev: make get_pointer() handle
 temporary strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>

On Mon, 3 Mar 2014 10:41:30 +0100
Stefan Hajnoczi <stefanha@redhat.com> wrote:

> On Fri, Feb 28, 2014 at 05:49:09PM +0100, Andreas F=E4rber wrote:
> > Am 28.02.2014 16:18, schrieb Stefan Hajnoczi:
> > > From: Igor Mammedov <imammedo@redhat.com>
> > >=20
> > > get_pointer()'s print() callback might return a heap allocated
> > > string, to avoid adding dedicated get_pointer_foo for this case
> > > convert current print() callbacks to return temporary heap
> > > allocated string and make get_pointer() free it.
> > >=20
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > > ---
> > >  hw/core/qdev-properties-system.c | 19 +++++++++++--------
> > >  1 file changed, 11 insertions(+), 8 deletions(-)
> >=20
> > Not aware of the history of this patch (not CC'ed?) but looks okay,
> >=20
> > Reviewed-by: Andreas F=E4rber <afaerber@suse.de>
> >=20
> > Do we have any users outside of this series?
>=20
> The patch comes from Igor originally so maybe he has future patches that
> will use it.
>
> Stefan

I don't have other users/plans to use it.
Patch was suggested as alternative to adding a new API:
 http://lists.gnu.org/archive/html/qemu-devel/2014-02/msg04704.html