From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48106)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WKYIx-0005Dp-Gg
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 14:13:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WKYIr-0001RM-8v
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 14:13:35 -0500
Received: from lnantes-156-75-100-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:55637 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WKYIr-0001Qy-3N
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 14:13:29 -0500
Date: Mon, 3 Mar 2014 20:13:28 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140303191327.GA3796@irqsave.net>
References: <1393870294-19351-1-git-send-email-benoit.canet@irqsave.net>
	<1393870294-19351-2-git-send-email-benoit.canet@irqsave.net>
	<5314CB61.7090401@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5314CB61.7090401@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization
 mechanism for block filters.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com

The Monday 03 Mar 2014 =E0 19:35:13 (+0100), Paolo Bonzini wrote :
> Il 03/03/2014 19:11, Beno=EEt Canet ha scritto:
> >diff --git a/block/blkverify.c b/block/blkverify.c
> >index b98b08b..e1c3117 100644
> >--- a/block/blkverify.c
> >+++ b/block/blkverify.c
> >@@ -288,6 +288,20 @@ static BlockDriverAIOCB *blkverify_aio_flush(Bloc=
kDriverState *bs,
> >     return bdrv_aio_flush(s->test_file, cb, opaque);
> > }
> >
> >+static bool blkverify_recurse_is_first_non_filter(BlockDriverState *b=
s,
> >+                                                  BlockDriverState *c=
andidate)
> >+{
> >+    BDRVBlkverifyState *s =3D bs->opaque;
> >+
> >+    bool perm =3D bdrv_recurse_is_first_non_filter(bs->file, candidat=
e);
> >+
> >+    if (perm) {
> >+        return true;
> >+    }
> >+
> >+    return bdrv_recurse_is_first_non_filter(s->test_file, candidate);
>=20
> Thanks!  Is this a silent bugfix? :)
>=20
> It is a behavior change from before, because BS_FILTER_PASS_DOWN
> only tested bs->file.

Hmm I did not even though it was a bug, I merely rewrote the code to adap=
t to
the new way of doing.

Should I mention the bugfix and repost ?

Best regards

Beno=EEt

>=20
> Paolo