From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55693)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WKsT5-0005Wv-5e
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 11:45:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WKsT0-0002Uu-3R
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 11:45:23 -0500
Received: from lnantes-156-75-100-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:55672 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1WKsSz-0002Un-T4
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 11:45:18 -0500
Date: Tue, 4 Mar 2014 17:45:18 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140304164518.GC3253@irqsave.net>
References: <dcf6d10cbc91d6acc08f5daf6eff8306a96f7688.1393947210.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <dcf6d10cbc91d6acc08f5daf6eff8306a96f7688.1393947210.git.jcody@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] block: mirror - remove code cruft that has
 no function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

The Tuesday 04 Mar 2014 =E0 10:35:48 (-0500), Jeff Cody wrote :
> Originally, this built up the error message with the backing filename,
> so that errp was set as follows:
>     error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename);
>=20
> However, we now propagate the local_error from the
> bdrv_open_backing_file() call instead, making these 2 lines useless
> code.
>=20
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  block/mirror.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/block/mirror.c b/block/mirror.c
> index e683959..dd5ee05 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -520,9 +520,6 @@ static void mirror_complete(BlockJob *job, Error **=
errp)
> =20
>      ret =3D bdrv_open_backing_file(s->target, NULL, &local_err);
>      if (ret < 0) {
> -        char backing_filename[PATH_MAX];
> -        bdrv_get_full_backing_filename(s->target, backing_filename,
> -                                       sizeof(backing_filename));
>          error_propagate(errp, local_err);
>          return;
>      }
> --=20
> 1.8.3.1
>=20
>=20
Reviewed-by: Benoit Canet <benoit@irqsave.net>