From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44448)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WLByb-0002TM-Vu
	for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 08:35:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WLByY-0003cU-2G
	for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 08:35:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:24450)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1WLByX-0003cK-QS
	for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 08:35:10 -0500
Date: Wed, 5 Mar 2014 14:35:00 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20140305133500.GD20321@stefanha-thinkpad.muc.redhat.com>
References: <53170860.2040100@cisco.com>
 <53170E5A.10104@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <53170E5A.10104@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Contribution - L2TPv3 - resubmit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Anton Ivanov (antivano)" <antivano@cisco.com>
Cc: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, "Qemu-devel@nongnu.org" <Qemu-devel@nongnu.org>

On Wed, Mar 05, 2014 at 12:45:30PM +0100, Andreas F=E4rber wrote:
> Hi,
>=20
> Am 05.03.2014 12:20, schrieb Anton Ivanov (antivano):
> > This is a functional driver which will interoperate versus most L2TPv=
3=20
> > implementations. It cannot be split into smaller patches - this is an=
=20
> > entire transport.
> [snip]
>=20
> Please see http://wiki.qemu.org/Contribute/SubmitAPatch - in particular
> the patch should be sent as inline text rather than as attachment (so
> that we can comment inline on it), also it is missing a Signed-off-by
> (without it patches cannot get accepted) and the commit message should
> be suitable for committing. Any other text can go into a cover letter
> 0/1 or below --- line. You also forgot to CC the net maintainer.

Besides the guidelines on the wiki a quick tip:

Dry run git-send-email(1) by sending to your own email address first.
Pick patch at random on the QEMU mailing list and compare whether the
structure/style matches yours.

Once you're ready, send to qemu-devel@nongnu.org and CC
stefanha@redhat.com, afaerber@suse.de, eblake@redhat.com,
pbonzini@redhat.com.

If you get stuck, feel free to hop on #qemu on irc.oftc.net and we can
chat about how to configure git-send-email(1).

Stefan