From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLD2G-0003wH-2D for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:43:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLD2B-0002wN-Sa for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:43:03 -0500 Date: Wed, 5 Mar 2014 14:40:33 +0000 From: "Daniel P. Berrange" Message-ID: <20140305144033.GJ1993@redhat.com> References: <49b80c368134449bb2b9093204aef6b6@BL2PR03MB210.namprd03.prod.outlook.com> <53170DFB.5050005@ozlabs.ru> <53172815.50806@redhat.com> <20140305134011.GH1993@redhat.com> <531730D8.6010607@redhat.com> <20140305142134.GI1993@redhat.com> <531735C3.3010203@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <531735C3.3010203@redhat.com> Subject: Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Hong-Hua.Yin@freescale.com" , Alexey Kardashevskiy , "qemu-devel@nongnu.org" , Li Zhang , "agraf@suse.de" , "qemu-ppc@nongnu.org" , "david@gibson.dropbear.id.au" On Wed, Mar 05, 2014 at 03:33:39PM +0100, Paolo Bonzini wrote: > Il 05/03/2014 15:21, Daniel P. Berrange ha scritto: > >>alpha/typhoon.c: b = pci_register_bus(dev, "pci", > >>mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", > >>pci-host/apb.c: phb->bus = pci_register_bus(DEVICE(phb), "pci", > >>pci-host/bonito.c: phb->bus = pci_register_bus(DEVICE(dev), "pci", > >>sh4/sh_pci.c: phb->bus = pci_register_bus(DEVICE(dev), "pci", > >>pci-host/versatile.c: pci_bus_new_inplace(&s->pci_bus, sizeof(s->pci_bus), DEVICE(obj), "pci", > >> > >>plus pseries which has its own rules because it supports multiple PCI > >>host bridges, but probably can also be changed from "pci" to NULL. > > > >I'm not sure I understand the effect of changing 'pci' to NULL in this > >code, from libvirt's POV. Would using NULL mean we can rely on using > >"pci.0" as the default PCI bus name or not ? > > Yes. But the next bus that the user creates (e.g. from a PCI bridge > without an "id") would be "pci.1" instead of having a duplicate > "pci.0"). Needs a bit more testing of course. That sounds OK from libvirt's POV, since when we create secondary buses we'll always set an ID value explicitly anyway. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|