From: Kevin Wolf <kwolf@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>
Cc: Benoit Canet <benoit@irqsave.net>,
qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs graph node list field.
Date: Thu, 6 Mar 2014 11:33:29 +0100 [thread overview]
Message-ID: <20140306103329.GB2663@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1394059709-7883-2-git-send-email-benoit.canet@irqsave.net>
Am 05.03.2014 um 23:48 hat Benoît Canet geschrieben:
> Moving only the node_name one field could lead to some inconsitencies where a
> node_name was defined on a bs which was not registered in the graph node list.
>
> bdrv_swap between a named node bs and a non named node bs would lead to this.
>
> bdrv_make_anon would then crash because it would try to remove the bs from the
> graph node list while it is not in it.
>
> This patch remove named node bses from the graph node list before doing the swap
> then insert them back.
>
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch.
Kevin
next prev parent reply other threads:[~2014-03-06 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 22:48 [Qemu-devel] [QEMU 2.0 FIX V2] Fix bdrv_swap behavior regarding the node graph Benoît Canet
2014-03-05 22:48 ` [Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs graph node list field Benoît Canet
2014-03-06 10:33 ` Kevin Wolf [this message]
2014-03-06 10:45 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306103329.GB2663@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=benoit@irqsave.net \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).