From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLVcU-0001X6-L0 for qemu-devel@nongnu.org; Thu, 06 Mar 2014 05:33:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLVcP-0003fK-JK for qemu-devel@nongnu.org; Thu, 06 Mar 2014 05:33:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLVcP-0003fC-Bt for qemu-devel@nongnu.org; Thu, 06 Mar 2014 05:33:37 -0500 Date: Thu, 6 Mar 2014 11:33:29 +0100 From: Kevin Wolf Message-ID: <20140306103329.GB2663@dhcp-200-207.str.redhat.com> References: <1394059709-7883-1-git-send-email-benoit.canet@irqsave.net> <1394059709-7883-2-git-send-email-benoit.canet@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1394059709-7883-2-git-send-email-benoit.canet@irqsave.net> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [QEMU 2.0 FIX V2] block: make bdrv_swap rebuild the bs graph node list field. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Beno=EEt?= Canet Cc: Benoit Canet , qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Am 05.03.2014 um 23:48 hat Beno=EEt Canet geschrieben: > Moving only the node_name one field could lead to some inconsitencies w= here a > node_name was defined on a bs which was not registered in the graph nod= e list. >=20 > bdrv_swap between a named node bs and a non named node bs would lead to= this. >=20 > bdrv_make_anon would then crash because it would try to remove the bs f= rom the > graph node list while it is not in it. >=20 > This patch remove named node bses from the graph node list before doing= the swap > then insert them back. >=20 > Signed-off-by: Benoit Canet > Reviewed-by: Max Reitz Thanks, applied to the block branch. Kevin