From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLVn3-0000xv-0c for qemu-devel@nongnu.org; Thu, 06 Mar 2014 05:44:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLVmu-0007Jn-JC for qemu-devel@nongnu.org; Thu, 06 Mar 2014 05:44:36 -0500 Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:59352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLVmu-0007JN-Bu for qemu-devel@nongnu.org; Thu, 06 Mar 2014 05:44:28 -0500 Received: by mail-ee0-f44.google.com with SMTP id e49so1033013eek.3 for ; Thu, 06 Mar 2014 02:44:27 -0800 (PST) Date: Thu, 6 Mar 2014 11:44:24 +0100 From: Stefan Hajnoczi Message-ID: <20140306104424.GH23172@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] block: mirror - remove code cruft that has no function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Mar 04, 2014 at 10:35:48AM -0500, Jeff Cody wrote: > Originally, this built up the error message with the backing filename, > so that errp was set as follows: > error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename); > > However, we now propagate the local_error from the > bdrv_open_backing_file() call instead, making these 2 lines useless > code. > > Signed-off-by: Jeff Cody > --- > block/mirror.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/block/mirror.c b/block/mirror.c > index e683959..dd5ee05 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -520,9 +520,6 @@ static void mirror_complete(BlockJob *job, Error **errp) > > ret = bdrv_open_backing_file(s->target, NULL, &local_err); > if (ret < 0) { > - char backing_filename[PATH_MAX]; > - bdrv_get_full_backing_filename(s->target, backing_filename, > - sizeof(backing_filename)); > error_propagate(errp, local_err); > return; > } Acked-by: Stefan Hajnoczi