From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] block: mirror - remove code cruft that has no function
Date: Thu, 6 Mar 2014 11:48:30 +0100 [thread overview]
Message-ID: <20140306104830.GD2663@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <dcf6d10cbc91d6acc08f5daf6eff8306a96f7688.1393947210.git.jcody@redhat.com>
Am 04.03.2014 um 16:35 hat Jeff Cody geschrieben:
> Originally, this built up the error message with the backing filename,
> so that errp was set as follows:
> error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename);
>
> However, we now propagate the local_error from the
> bdrv_open_backing_file() call instead, making these 2 lines useless
> code.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2014-03-06 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 15:35 [Qemu-devel] [PATCH] block: mirror - remove code cruft that has no function Jeff Cody
2014-03-04 15:55 ` Eric Blake
2014-03-04 16:45 ` Benoît Canet
2014-03-06 10:44 ` Stefan Hajnoczi
2014-03-06 10:48 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306104830.GD2663@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).