From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WLVsE-0005F5-L9
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 05:50:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1WLVs9-0000XS-4A
	for qemu-devel@nongnu.org; Thu, 06 Mar 2014 05:49:58 -0500
Date: Thu, 6 Mar 2014 11:49:37 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20140306104937.GI23172@stefanha-thinkpad.redhat.com>
References: <1394054580-29120-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1394054580-29120-1-git-send-email-sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: Fix warnings from static code
 analysis
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Wed, Mar 05, 2014 at 10:23:00PM +0100, Stefan Weil wrote:
> Smatch complains about several global symbols which should be local.
> 
> Add the missing 'static' attributes and move the 'extern' declaration
> of variable qemuio_misalign to qemu-io.h. This variable also changes
> the type from 'int' to 'bool' which better fits documents its use.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  include/qemu-io.h |    2 ++
>  qemu-io-cmds.c    |    2 +-
>  qemu-io.c         |    7 +++----
>  3 files changed, 6 insertions(+), 5 deletions(-)

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>