From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLWpC-0001D0-7v for qemu-devel@nongnu.org; Thu, 06 Mar 2014 06:50:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLWp8-0003KT-FY for qemu-devel@nongnu.org; Thu, 06 Mar 2014 06:50:54 -0500 Date: Thu, 6 Mar 2014 11:50:42 +0000 From: "Daniel P. Berrange" Message-ID: <20140306115042.GA1821@redhat.com> References: <1394075460-17400-1-git-send-email-aik@ozlabs.ru> <53186050.8030503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <53186050.8030503@redhat.com> Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Hong-Hua . Yin @ freescale . com" , Alexey Kardashevskiy , qemu-devel@nongnu.org, Alexander Graf , qemu-ppc@nongnu.org, Andreas =?utf-8?Q?F=C3=A4rber?= On Thu, Mar 06, 2014 at 12:47:28PM +0100, Paolo Bonzini wrote: > Il 06/03/2014 04:11, Alexey Kardashevskiy ha scritto: > >Previously libvirt required the first/default PCI bus to have name "pci". > >Since QEMU can support multiple buses now, libvirt wants "pci.0" now. > > > >This removes custom busname and lets QEMU make up default names. > > > >Signed-off-by: Alexey Kardashevskiy > >--- > > > >I tested this with: > > -netdev tap,id=id0,ifname=tapqemu-tap-00,script=ifup.sh,downscript=ifdown.sh \ > > -device e1000,id=id1,netdev=id0,mac=C0:41:49:4b:00:00 \ > > -device \ > > spapr-pci-host-bridge,index=5,id=aikbus \ > > -netdev tap,id=id2,ifname=tap-1,script=ifup.sh,downscript=ifdown.sh \ > > -device rtl8139,id=id3,netdev=id2,bus=aikbus.0,mac=C0:41:49:4b:00:01 \ > > -device spapr-pci-vfio-host-bridge,id=id4,index=10,iommu=4 \ > > > >This creates a default PCI, an additional emulated PCI bus (named aikbus, > >if I omit the name, it is pci.1 which is also fine) and VFIO bus (which is > >not in upstream yet but still), this all works fine and I cannot see any flaw. > > Thanks! > > Andreas, are you taking this patch? I'd like to see this change done across all machines, not just this ppc one, so that libvirt can do 1 single version check and know that the new naming applies for everything from that point. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|